[pigeon] [swift] Changes PigeonError class to conform to Sendable.
#8302
Conversation
bc-lee
requested review from
hellohuanlin,
LouiseHsu and
tarrinneal
as code owners
|
This will break old sdk where Sendable is undefined. You may have to put it behind a flag. |
Are there any minimum Xcode requirements for Flutter projects? Sendable was added in Xcode 13.0 with Swift 5.5. |
packages/pigeon/CHANGELOG.md
Outdated
| @@ -1,6 +1,7 @@ | |||
| ## NEXT | |||
There was a problem hiding this comment.
This should be updated to 22.7.1 along with the pubspec version and the generator_tools file.
I guess this is technically a breaking change, so 23.0.0 might be more correct.
packages/pigeon/CHANGELOG.md
Outdated
| @@ -1,6 +1,7 @@ | |||
| ## NEXT | |||
|
|
|||
| * Updates minimum supported SDK version to Flutter 3.22/Dart 3.4. | |||
| * [swift] Make `PigeonError` Class Conform to `Sendable` | |||
There was a problem hiding this comment.
[swift] Changes `PigeonError` class to conform to `Sendable`.
|
@stuartmorgan shouldn't this pr be failing the test exemption check? |
bc-lee
changed the title
PigeonError Class Conform to SendablePigeonError class to conform to Sendable.
There was a problem hiding this comment.
@stuartmorgan shouldn't this pr be failing the test exemption check?
I think there's a false negative due to the changes to generated files in platform_tests; we should probably tune the Cocoon rules to ignore .gen. files in there.
Regardless, this does need testing. A Dart unit test should be fine for this for now (although long term we probably want to adjust the Swift integration tests to actually test a flow that ensures that everything is Sendable)
I have added the Dart test introduced by this PR. I also agree that the long-term solution would involve updating the Swift integration tests—not just to check for |
Make
PigeonErrorconform toSendablefor compatibility with Swift 6.0 mode by changing thedetailsproperty type fromAny?toSendable?.Fixes flutter/flutter#160313
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.